Mark XCTest suites as passed/failed immediately on suite completion #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
xctest-suite-immediate-test-results
branch
from
12eb294
to
123ec70
Compare
Add back some code that was removed that marked XCTest suites as passed/failed as soon as all their tests completed. Currently the TestExplorer shows the test suites as pending until all tests in the whole test run have completed. This is a regression from how the Test Explorer used to work, where suites were marked as passed/failed immediately upon suite completion. Issue: swiftlang#1029
plemarquand
force-pushed
the
xctest-suite-immediate-test-results
branch
from
123ec70
to
3fcd09d
Compare
award999
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back some code that was removed that marked XCTest suites as passed/failed as soon as all their tests completed. Currently the TestExplorer shows the test suites as pending until all tests in the whole test run have completed. This is a regression from how the Test Explorer used to work, where suites were marked as passed/failed immediately upon suite completion.
Issue: #1029